Skip to content

ix(RELEASE-2104): remove alert ReleaseServiceControllerManagerAvailability #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubasikus merged 1 commit into from
Jan 7, 2026
Merged

ix(RELEASE-2104): remove alert ReleaseServiceControllerManagerAvailability #960

kubasikus merged 1 commit into from
Jan 7, 2026
+0 −59

Conversation

@theflockers
Copy link
Member

@theflockers theflockers commented Jan 5, 2026 •
edited by kubasikus
Loading

Description

Pre-Submission Checklist

  • Jira Ticket: If a corresponding Jira ticket exists, it is linked in the description above, in the PR name, and/or in the commit message.
  • Alert Tests: New or modified alerts include tests to ensure they function correctly.
  • SOP / Runbook: Any required SOP has been created or updated as needed. If it has direct connection to the dashboard or alert - It should be included within the dashboard or alert's runbook label respectively.
  • Dashboards Addition: New dashboards or significant changes to them should have a link to the staging instance for validation purposes.
  • Contribution Guides: This submission follows the guidelines in our CONTRIBUTING.md - specifically about the commit conventions and PR instructions - together with our README.md which explains contents of this repository with useful examples for contribution.
  • Pipeline Finished Successfully

Deployment Notice

  • Production Deployment: For any changes to alerts, recording rules or dashboards, I understand that the deployment of changes to production requires updating the commit reference to o11y in app-interface repository.

Review

Once your PR is ready please let us know in the #forum-konflux-o11y slack channel. Tag @konflux-o11y-ic for assistance.

@theflockers
fix(RELEASE-2104): remove alert ReleaseServiceControllerManagerAvaila…
5b8ba66 
…bility

The alert ReleaseServiceControllerManagerAvailability was
initially thought to report when the overall availability
of the service was below 99%, but in reality after lots of
changes to decrease the noise, it does not reflect the
initial desire, which was not to be a UP/DOWN alert.
That being said, I am removing this in favor of the exis-
tant one `ReleaseServiceControllerManagerPodNotReady` that
already does UP/DOWN properly.
@theflockers theflockers marked this pull request as ready for review January 6, 2026 15:17
gcpsoares
gcpsoares approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@gcpsoares gcpsoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theflockers theflockers changed the title fix: test fix suggested by gasoares ix(RELEASE-2104): remove alert ReleaseServiceControllerManagerAvailability Jan 7, 2026
FilipNikolovski
FilipNikolovski approved these changes Jan 7, 2026
View reviewed changes
Copy link

@FilipNikolovski FilipNikolovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kubasikus kubasikus merged commit 23ccb91 into redhat-appstudio:main Jan 7, 2026
2 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jan 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kubasikus kubasikus kubasikus approved these changes

@gcpsoares gcpsoares gcpsoares approved these changes

+1 more reviewer

@FilipNikolovski FilipNikolovski FilipNikolovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theflockers @FilipNikolovski @kubasikus @gcpsoares