fixed waitFor condition in start-pipeline step to handle empty string #1025
Conversation
WalkthroughThe change adds an explicit wait condition in the integration test pipeline to ensure the nested pipeline run's "Succeeded" status is initialized (non-empty) before waiting for it to reach a terminal state. Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xinredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
integration-tests/pipelines/e2e-main-pipeline.yaml (1)
184-184: Simplify empty-string check for better readabilityThe added fallback for an unset status is spot-on 👍.
Consider using the-zunary test instead of a second string comparison – it is more idiomatic Bash and avoids the extra quoting boiler-plate:-waitFor 'STATUS=$(oc get pipelinerun/$PIPELINE_RUN -n ${KONFLUX_NAMESPACE} -o jsonpath="{.status.conditions[?(@.type==\"Succeeded\")].status}" 2>/dev/null || echo ""); [[ "$STATUS" == "Unknown" ]] || [[ "$STATUS" == "" ]]' "Nested pipelines are still running. Waiting 1 minute" "All nested pipelines finished" +waitFor 'STATUS=$(oc get pipelinerun/$PIPELINE_RUN -n ${KONFLUX_NAMESPACE} -o jsonpath="{.status.conditions[?(@.type==\"Succeeded\")].status}" 2>/dev/null || echo ""); [[ "$STATUS" == "Unknown" ]] || [[ -z "$STATUS" ]]' "Nested pipelines are still running. Waiting 1 minute" "All nested pipelines finished"Functionally identical, but a bit clearer to the next reader.
No other issues spotted with the new condition.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
integration-tests/pipelines/e2e-main-pipeline.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Red Hat Konflux / rhtap-cli-on-pull-request
xinredhat
force-pushed
the
fix_main_pipeline
branch
from
e57e9d7 to
914c516
Compare
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
xinredhat
force-pushed
the
fix_main_pipeline
branch
from
914c516 to
1e7b048
Compare
|
xinredhat
changed the title
xinredhat
changed the title
|
/lgtm |
openshift-merge-bot
bot
merged commit 1b5d04a
into
redhat-appstudio:main
3 participants
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Summary by CodeRabbit