Do not stream logs. Print URL to nested PLR instead. #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhopp
force-pushed
the
removeNestedLogs
branch
from
b914b34 to
2c1b5ff
Compare
prietyc123
reviewed
Jan 3, 2025
Contributor
Author
|
/retest |
rhopp
force-pushed
the
removeNestedLogs
branch
3 times, most recently
from
261b416 to
b84d12f
Compare
rhopp
force-pushed
the
removeNestedLogs
branch
from
b84d12f to
0306dbf
Compare
|
rhopp
changed the title
lcarva
reviewed
Jan 9, 2025
lcarva
approved these changes
Jan 9, 2025
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva, prietyc123, rhopp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4ac9af2
into
redhat-appstudio:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the log streaming from nested PLRs to clean up the output. Instead of that it will print link to the nested pipelineruns.