Skip to content
This repository was archived by the owner on Oct 3, 2019. It is now read-only.

Conversation

@baijum
Copy link
Collaborator

@baijum baijum commented May 3, 2019

The CI configuration will be updated to receive this:

- from: operator-registry
  inputs:
    bin:
      paths:
      - destination_dir: .
        source_path: /go/src/github.com/redhat-developer/devconsole-operator/out/csv.tar.gz
  dockerfile_path: openshift-ci/Dockerfile.registry.build
  to: devconsole-operator-registry

The bin build will be modified like this:

binary_build_commands: make ci-build

The CI configuration will be updated to receive this:

- from: operator-registry
  inputs:
    bin:
      paths:
      - destination_dir: .
        source_path: /go/src/github.com/redhat-developer/devconsole-operator/out/csv.tar.gz
  dockerfile_path: openshift-ci/Dockerfile.registry.build
  to: devconsole-operator-registry
@baijum baijum requested a review from sbose78 May 3, 2019 11:56
@baijum baijum changed the title Create Makefile target to build & bundle CSV file [WIP] Create Makefile target to build & bundle CSV file May 3, 2019
@baijum baijum requested review from Avni-Sharma and removed request for michaelkleinhenz May 3, 2019 12:05
@openshift-ci-robot
Copy link
Collaborator

@baijum: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 948ef74 link /test images
ci/prow/e2e 948ef74 link /test e2e
ci/prow/e2e-ci 948ef74 link /test e2e-ci

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is innovative. Nice!

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbose78 sbose78 self-requested a review May 3, 2019 13:03
@baijum
Copy link
Collaborator Author

baijum commented May 3, 2019

/hold

@baijum
Copy link
Collaborator Author

baijum commented May 3, 2019

This is innovative. Nice!

Thanks!

I preferred to go for an intermediate image approach which looks relatively better.
#179

Looks like OML integration test is passing: openshift/release#3634

@baijum baijum closed this May 3, 2019
@baijum baijum deleted the ci-build-csv branch May 4, 2019 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants