[v2] Add duplicate port validation, update devfile libraries, and add tests to check port name matches endpoint name #5499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to check port name matches endpoint name
valaparthvi
force-pushed
the
duplicate_port_v2
branch
from
e110ab7 to
9ff357a
Compare
Signed-off-by: Parthvi Vala <pvala@redhat.com>
valaparthvi
force-pushed
the
duplicate_port_v2
branch
from
9ff357a to
02d9aeb
Compare
|
✔️ Deploy Preview for odo-docusaurus-preview canceled. 🔨 Explore the source changes: dcddf2b 🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/621db6ad41281d000876b09a |
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #5407.
A manual cherry-pick is required since a lot of tests removed from v3 are still present in v2. This PR fixes v2 tests as well.