No feedback on failed build

[DarkLite1]

Within GitHub Actions we see all checkmarks green:

When going into the OpenShift Action:

But in the Builds section of OpenShift we see this:

In the OpenShift logs:

App · Reading quasar.conf.js
--
  | App · Transpiling JS (Babel active) - includes IE11 support
  | App · Extending SPA Webpack config
  | App · Cleaned build artifact: "/opt/app-root/src/dist/spa"
  | App · Generating Webpack entry point
  | App · Compiling with Webpack...
  | Starting type checking service...
  | App · Compiling SPA...
  | App · Compiled SPA done in 38592 ms
  | App · Added build artifact "/opt/app-root/src/dist/spa"
  |  
  | App · ⚠️  2 errors encountered:
  |  
  | /opt/app-root/src/codegen.js
  | ERROR in /opt/app-root/src/codegen.js(3,7):
  | @typescript-eslint/no-unsafe-assignment: Unsafe assignment of an any value.
  | /opt/app-root/src/codegen.js
  | ERROR in /opt/app-root/src/codegen.js(10,6):
  | @typescript-eslint/no-unsafe-member-access: Unsafe member access .resources on an any value.
  |  
  | App · ⚠️  [FAIL] Build failed with 2 errors. Check log above.
  |  
  | npm info lifecycle hip@0.0.1~quasar-build: Failed to exec quasar-build script
  | npm ERR! code ELIFECYCLE
  | npm ERR! errno 1
  | npm ERR! hip@0.0.1 quasar-build: `quasar build`
  | npm ERR! Exit status 1
  | npm ERR!
  | npm ERR! Failed at the hip@0.0.1 quasar-build script.
  | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
  | npm timing npm Completed in 44443ms
  |  
  | npm ERR! A complete log of this run can be found in:
  | npm ERR!     /opt/app-root/src/.npm/_logs/2020-09-10T13_27_53_052Z-debug.log
  | ERROR: "quasar-build" exited with 1.
  | npm info lifecycle hip@0.0.1~build: Failed to exec build script
  | npm ERR! code ELIFECYCLE
  | npm ERR! errno 1
  | npm ERR! hip@0.0.1 build: `run-s quasar-clean quasar-build`
  | npm ERR! Exit status 1
  | npm ERR!
  | npm ERR! Failed at the hip@0.0.1 build script.
  | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
  | npm timing npm Completed in 46938ms
  |  
  | npm ERR! A complete log of this run can be found in:
  | npm ERR!     /opt/app-root/src/.npm/_logs/2020-09-10T13_27_53_080Z-debug.log
  | error: build error: non-zero (13) exit code from nodeshift/centos7-s2i-web-app@sha256:7b806bbc6d66f9e84c6209791b601660acdd96c85fe0ebd27dfc2a1a349cabae

There was indeed something wrong with the app which made the build fail. However, this was not signaled back to GitHub Actions I believe. It would've been great to see GitHub Actions fail too with a red cross.

[lstocchi]

Thanks for the feedback @DarkLite1 , really appreciate it. I'll give it a look asap.

[DarkLite1]

You're welcome :) I thought I would mention this as GitHub Actions wasn't inline with OpenShift.

PS: On a side note. I was thinking it might be a good idea to be able to lose the so called "builder image" on OpenShift so there's only the "nginx" image for serving the static files. It would mean one less container needed and probably faster to build on OpenShift too. The other side of the coin is that the quasar build process than needs to run on GitHub Actions and the output needs to be put in the "mginx" image one way or the other. Still thinking about this approach...