chore: bump dependencies to go 1.22#123
Closed
coreydaley wants to merge 4 commits intoredhat-developer:mainfrom
coreydaley:2024-08-29-bump-deps
Closed
chore: bump dependencies to go 1.22#123coreydaley wants to merge 4 commits intoredhat-developer:mainfrom coreydaley:2024-08-29-bump-deps
coreydaley wants to merge 4 commits intoredhat-developer:mainfrom
coreydaley:2024-08-29-bump-deps
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gazarenkov
requested changes
Sep 2, 2024
| module redhat-developer/red-hat-developer-hub-operator | ||
|
|
||
| go 1.21 | ||
| go 1.22.6 |
Member
There was a problem hiding this comment.
We can not bump it to 1.22 due to
https://catalog.redhat.com/software/containers/rhel9/go-toolset/61df08166d9a1b7b2aab2344
Member
|
Closing based on Gennady's feedback. I've opened https://issues.redhat.com/browse/RHIDP-3880 to track doing the go 1.22 update at a later date (ie., November, unless there's an urgency before then) |
nickboldt
changed the title
Fortune-Ndlovu
pushed a commit
to Fortune-Ndlovu/rhdh-operator
that referenced
this pull request
Sep 6, 2025
…er#73 ) (redhat-developer#123) * chore: adjust makefile to be able to use in GH action (janus-idp/operator#73 ) Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> also make sure podman is installed Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> add linting to the PR check, so we can basically remove py.yaml Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> update matrix PR check job so it'll work, if we still want it (but I'd argue we can delete it) Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> rename actions since they don't necessarily need docker to build container Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> * compute BASE_VERSION from makefile declaration of 'VERSION ?= 0.0.1' and use that in pr and next tags, so we have separation between releases; this will require that we update the Makefile after every release (eg., 0.0.1, 0.0.2, 0.0.3) Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> tweak comment: also pushing a :next tag Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> * typo fix: BUILDPLATFORM not defined but PLATFORMS is Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> BUILDPLATFORM is required by the dockerfile for cross-compilation with buildx; however the --platform flag should not be --platform= Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> * more refactorings to replace docker- and Docker with '' Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> * add note that catalog-build requires bundle-publish stage Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> * add podman back into the PR check, even though it's redundant to the other pr check Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> --------- Signed-off-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com> Co-authored-by: RHDH Build (rhdh-bot) <rhdh-bot@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Which issue(s) does this PR fix or relate to
PR acceptance criteria
rhdh-operator.csv.yamlfile accordinglyHow to test changes / Special notes to the reviewer