Skip to content

chore(e2e): e2e tests should not depend on external resources like roadiehq#3747

Merged
gustavolira merged 1 commit intoredhat-developer:mainfrom
gustavolira:RHDHBUGS-2071
Nov 25, 2025
Merged

chore(e2e): e2e tests should not depend on external resources like roadiehq#3747
gustavolira merged 1 commit intoredhat-developer:mainfrom
gustavolira:RHDHBUGS-2071

Conversation

@gustavolira
Copy link
Member

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign albarbaro for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

@gustavolira gustavolira merged commit e21907a into redhat-developer:main Nov 25, 2025
12 of 13 checks passed
Zaperex added a commit to Zaperex/rhdh that referenced this pull request Nov 27, 2025
* chore: update next builds to be hermetic

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: migrate to use downstream dockerfile as default

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: update symlinks for aarch64

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: refactor docker build setup

- Rename Dockerfile to Containerfile
- Adds a local hermeto build script for local testing
- Remove obsolete .rhdh directory and merged the doc content with docker

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: update the update-Dockerfile.sh script with updated containerfile locations

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: update docs and scripts with new container file location

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: remove dead janus slack invite link

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: update pr podman push with new artifact name

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: add missing architecture field in artifact names

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* chore: remove arch in artifacts since we don't do multi-arch for PRs

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* refactor: enhance GitHub Actions workflows with improved environment variable handling

- Moved many values into environmental variables for readability, maintainability and security (input sanitization).
- Deleted the on-new-issue.yaml workflow since we no longer create github issues.

These changes aim to improve readability and also follow best practices as defined in https://securitylab.github.com/resources/github-actions-untrusted-input/.

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* fix(gitlab): enable GitLab Discovery integration and fix E2E test (RHDHBUGS-1927) (redhat-developer#3741)

* RHDHBUGS-1927 gitlab-discovery.spec.ts - failing

* Update app-config and gitlab-discovery.spec to use GH_USER_ID account

* chore: allow writing contents; shorten timeout to 3hrs (we only need 90 mins, really); echo the diff we're about to commit for debugging purposes (RHIDP-9835) (redhat-developer#3743)

Signed-off-by: Nick Boldt <nboldt@redhat.com>

* fix(ci): remove re_create_k8s_service_account_and_get_token helper from K8s utils (redhat-developer#3708)

* refactor(ci): remove service account token creation from EKS and GKE job scripts

* refactor(ci): remove Kubernetes cluster URL export from EKS and GKE job scripts

* chore: increase ephemeral storage limit for dynamic plugins installation in Kubernetes manifests to prevent extraction errors

* chore: disable specific dynamic plugins in GKE to optimize disk space and skip related tests

* chore: disable additional orchestrator plugins in GKE and skip related tests to manage disk space

* chore: clean up flow issues (thanks, Cursor) - RHIDP-9835 (redhat-developer#3744)

Assisted-By: Cursor

Signed-off-by: Nick Boldt <nboldt@redhat.com>

* chore(deps): update dependency @types/react to v18.3.27 (redhat-developer#3715)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* RHDHBUGS-2071 e2e tests should not depend on external resources like roadiehq (redhat-developer#3747)

* Update apiVersion in backstage.yaml to v1alpha3 (redhat-developer#3750)

* chore: update workflows to use default github envs

Signed-off-by: Frank Kong <frkong@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

---------

Signed-off-by: Nick Boldt <nboldt@redhat.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Gustavo Lira e Silva <guga.java@gmail.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alessandro Barbarossa <abarbaro@redhat.com>
Fortune-Ndlovu pushed a commit to Fortune-Ndlovu/rhdh that referenced this pull request Dec 1, 2025
…roadiehq (redhat-developer#3747)

Assisted-by: Cursor
Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
@kim-tsao
Copy link
Member

/cherrypick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@kim-tsao: new pull request created: #4250

Details

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants