[release-1.8] fix(e2e): navigation changes to 1.8#4239
[release-1.8] fix(e2e): navigation changes to 1.8#4239kim-tsao merged 2 commits intoredhat-developer:release-1.8from
Conversation
|
The image is available at: |
|
/retest |
|
The PR is failing on the settings page due to missing translations. This issue was fixed in 1.8, which suggests that the image being used for the PR tests might be outdated or different from what is expected. |
|
@teknaS47: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The image is available at: |
|
There are 2 failures; one of them is caused by a URL to a file that no longer exists. This was fixed in 1.9 but not backported. The cherrypick PR should fix this. The other is a failure in the settings test. Seems like a timing issue where the expected French translation does not show up but I've seen this in another PR so it's not related to these changes. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b74eb33
into
redhat-developer:release-1.8
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer