Skip to content

[release-1.8] fix(e2e): navigation changes to 1.8#4239

Merged
kim-tsao merged 2 commits intoredhat-developer:release-1.8from
teknaS47:navigation-fixes-1.8-v2
Feb 13, 2026
Merged

[release-1.8] fix(e2e): navigation changes to 1.8#4239
kim-tsao merged 2 commits intoredhat-developer:release-1.8from
teknaS47:navigation-fixes-1.8-v2

Conversation

@teknaS47
Copy link
Member

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@github-actions
Copy link
Contributor

@kim-tsao
Copy link
Member

/retest

@teknaS47
Copy link
Member Author

The PR is failing on the settings page due to missing translations. This issue was fixed in 1.8, which suggests that the image being used for the PR tests might be outdated or different from what is expected.
cc: @redhat-developer/rhdh-qe

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2026

@teknaS47: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm a433b90 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
Copy link
Contributor

@kim-tsao
Copy link
Member

There are 2 failures; one of them is caused by a URL to a file that no longer exists. This was fixed in 1.9 but not backported. The cherrypick PR should fix this. The other is a failure in the settings test. Seems like a timing issue where the expected French translation does not show up but I've seen this in another PR so it's not related to these changes.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit b74eb33 into redhat-developer:release-1.8 Feb 13, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants