[formatter] Set org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch=true by default

[fbricon]

Even though the jdt.ls sets it to true, org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch seems to be ignored.

The following code is not indented as expected:

public static void main(String[] args) {
    switch (args.length) {
    case 0:
        System.err.println("none");
        break;
    case 1:
        System.err.println("one");
        break;
    default:
        System.err.println("many");
    }
}

It should be formatted as:

public static void main(String[] args) {
    switch (args.length) {
        case 0:
            System.err.println("none");
            break;
        case 1:
            System.err.println("one");
            break;
        default:
            System.err.println("many");
    }
}

BTW the https://github.com/redhat-developer/vscode-java/blob/master/formatters/eclipse-formatter.xml template should also set it to true by default.

This is definitely a no-brainer.

[rgrunber]

Regarding why the setting in Java Core prefs seem to be ignored : There are 2 ways to set a formatting settings. We can do it in the Java Core options (eg. org.eclipse.jdt.core.prefs), or we can do it in the formatter (eg. formatter.xml). With the preferences listed, we only do it in the Java Core prefs.

Unfortunately, in https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java#L291-L294 , we take the Java Core preferences, and override any values with the default formatter settings.

This is why the fix is to also add them to the formatter settings. Since formatter settings can go in both places, I think it's worth setting up a common method to avoid such issues in the future.