Fix semantic tokens offset due to document updates#1632
Fix semantic tokens offset due to document updates#1632fbricon merged 1 commit intoredhat-developer:masterfrom
Conversation
|
travis chokes on ERROR: /home/travis/build/redhat-developer/vscode-java/src/semanticTokenProvider.ts[50, 13]: Identifier 'iv' is never reassigned; use 'const' instead of 'let'. |
|
Oh, sorry, I just copied the code from the TypeScript implementation. I'll fix it later today. |
Signed-off-by: 0dinD <zerodind@gmail.com>
0abc723 to
44c216c
Compare
|
@fbricon I've fixed up the code now. |
|
Thanks @0dinD, this seems to make a big difference, even without eclipse-jdtls/eclipse.jdt.ls#1552 |
|
No problem! When the document and compilation unit become out-of-sync on the server side without the client knowing, the token offset will become "stuck" until you change the document again, which is very annoying. |
Fixes #1597, together with eclipse-jdtls/eclipse.jdt.ls#1552
The fix is basically taken straight from the implementation of the TypeScript semantic token provider, see this line.