Skip to content

Use vsce 1.x since 2.x is not compatible with Node 12.x #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrunber merged 1 commit into from
Nov 5, 2021
Merged

Use vsce 1.x since 2.x is not compatible with Node 12.x #2195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
with:
java-version: '11'
distribution: 'adopt'
- run: npm install -g typescript vsce
- run: npm install -g typescript "vsce@<2"
- run: wget http://download.eclipse.org/jdtls/snapshots/jdt-language-server-latest.tar.gz
- run: mkdir server && tar -xvzf jdt-language-server-latest.tar.gz -C ./server && rm jdt-language-server-latest.tar.gz
- run: npm install
Expand Down
2 changes: 1 addition & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ def installBuildRequirements(){
def nodeHome = tool 'nodejs-12.13.1'
env.PATH="${env.PATH}:${nodeHome}/bin"
sh "npm install -g typescript"
sh "npm install -g vsce"
sh 'npm install -g "vsce@<2"'
Copy link
Copy Markdown
Collaborator

@testforstephen testforstephen Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, vsce@2.0 is just published 10 hours ago. We can keep 1.x first before we catch up 2.0 gap.

Copy link
Copy Markdown
Member Author

@rgrunber rgrunber Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the <2 is just so that we can continue getting 1.x updates without having to manually touch the build files every time.

}

def buildVscodeExtension(){
Expand Down