Update GH Actions release workflow #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DeLaGuardo/setup-graalvm -> graalvm/setup-graalvm - Remove 'release-binary-artifacts' since this is done from the 'release' workflow
rgrunber
commented
Sep 19, 2023
- The pre-release build now runs by default daily - Only proceed when there are new changes to eclipse/lemminx or redhat-developer/vscode-xml Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
check-for-changes
branch
from
a4de39f to
a628a96
Compare
Member
Author
|
Will be merging this later today. Based on my testing this should work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this change is to add the ability to publish a pre-release when there are changes to either lemminx or vscode-xml. This is done by having a daily scheduled workflow that has a job which checks out the 2 repositories, and determines if the recent commit (from both repos) have already been encountered in a previous build. This check is skipped if the build was manually triggered (assume the maintainer knows what they're doing).
https://github.com/DeLaGuardo/setup-graalvm/ has been archived since April 2023, so we should use https://github.com/graalvm/setup-graalvm
No need for workflow to release binary artifacts of lemminx in the native-image job, because we already do it in vscode-xml releases, (eg. https://github.com/redhat-developer/vscode-xml/releases/tag/0.26.1 .
Verify that the new binaries (resulting from the new setup-graalvm with version 22.3.3) work as expected.