Fix indent on enter for nested maps#1252
Merged
datho7561 merged 1 commit intoMay 15, 2026
Merged
Conversation
- Simplify code so that it adds or removes spaces based on what's already present instead of completely replacing it Fixes redhat-developer/vscode-yaml#1226 Signed-off-by: David Thompson <davthomp@redhat.com>
shin19991207
approved these changes
May 14, 2026
Member
shin19991207
left a comment
shin19991207
left a comment
There was a problem hiding this comment.
I couldn't reproduce the issue on my end but the code looks good to me!
Contributor
Author
|
Wait, really? Hmm, I'll double check before and after on my Mac locally before merging. |
Contributor
Author
|
I think maybe it's not on by default, I had to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes redhat-developer/vscode-yaml#1226
Is it tested? How?
Modified existing unit tests and added new ones for the nested cases