Contribution guidelines#3
Open
stoobie wants to merge 3 commits intoredhat-documentation:mainfrom
Open
Conversation
domiborges
reviewed
Aug 17, 2021
domiborges
left a comment
domiborges
left a comment
There was a problem hiding this comment.
Hey @stoobie I completed the review. Overall it's very simple and action oriented. I just added few comments/suggestions.
| 1. Remove `WIP` from the title of the pull request. | ||
| 1. Click **Request Review** and enter `@@redhat-documentation/publishing-tutorial-team`. | ||
|
|
||
| The developers check that the **Tech review complete** label has been added to the pull request and peer pull request approval provided, then accept it. |
There was a problem hiding this comment.
I'm a bit confused with "peer pull request approval provided" It seems that you wanted to say something like "that the reviewer approved the pull request" or something similar.
Collaborator
Author
There was a problem hiding this comment.
Yeah, actually, I don't think we need this same process here. I changed this section a bit.
domiborges
reviewed
Aug 19, 2021
|
|
||
| ### The review process | ||
|
|
||
| At least one person on the project team reviews the merge request and adds comments in GitHub. This review process will be open for one week from the day the merge request was submitted. If the merge request is still being actively discussed beyond the one week timeframe, then the merge request will stay open. Once the merge request discussion is resolved, the merge request will be NACK'd or ACK'd based on the comments given. If no comments are given after a week, then a project administrator will ACK the merge request. |
There was a problem hiding this comment.
Hey @stoobie the PR looks good. So do I understand correctly that as a reviewer I don't need to do anything? That if I don't object it's going to be merged in a week?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the Pantheon 2 repo README file.
@redhat-documentation/publishing-tutorial-team Please review.