Implement Write Barriers for HiredisConnection #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a bit of a hack here, for two reasons: First we'd need a reference to the connection from the parsing functions, it's possible but a bit annoying. Also if we were to fire write barriers ourselves from the connection object, we'd be very likely to promote the response objects to the old gen, which isn't desirable. So instead we allocate an RArray and keep a reference to it on the stack. That array is used to store the elements of the response being parsed.
casperisfine
force-pushed
the
refactor-reader
branch
from
e0d33fe to
873cef7
Compare
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a bit of a hack here, for two reasons:
First we'd need a reference to the connection from the parsing functions, it's possible but a bit annoying.
Also if we were to fire write barriers ourselves from the connection object, we'd be very likely to promote the response objects to the old gen, which isn't desirable.
So instead we allocate an RArray and keep a reference to it on the stack. That array is used to store the elements of the response being parsed.