Fixed CorsMiddleware::beforeHandleRoute #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the changes made by @thecharge in #1 the CorsMiddleware::beforeHandleRoute is completely broken. This is obvious because the $allowedOrigin variable is undefined now. Note: I've added the 'i' modifier to the regular expression. Refs: 4403145#diff-e0f68aa0c2eadb45e6b357a76fa5aa50 / cc: @bblok11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes made by @thecharge in #1
the
CorsMiddleware::beforeHandleRouteis completely broken.This is obvious because the
$allowedOriginvariable is undefined now.Note: I've added the
imodifier to the regular expression.Refs: 4403145#diff-e0f68aa0c2eadb45e6b357a76fa5aa50
/ cc: @bblok11, @olivierandriessen