Support for Python 3

[redtoad]

Originally reported by Sebastian Rahlf (Bitbucket: basti, GitHub: redtoad)

---

The module currently does not work python 3.1 (and above). This should be fixed for the next major release!

---

• Bitbucket: https://bitbucket.org/basti/python-amazon-product-api/issue/6

[redtoad]

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)

---

I've started on this issue:
<<changeset 737a2bd3c548>>

[redtoad]

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)

---

Drop support for Python 2.4 amd 2.5, add Python 3.3 (see #6).

[redtoad]

Original comment by abb (Bitbucket: abb, GitHub: abb)

---

added 2to3 call to setup.py if called with python3

[redtoad]

Original comment by abb (Bitbucket: abb, GitHub: abb)

---

forget my patch ... there is more unicode related stuff todo

[redtoad]

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)

---

For any Pyhton 3 related work I've created a separate branch*. Feel free to create a pull request rather than sending patches. Those are easier to work with.

'* It is really just a bookmark

[redtoad]

Original comment by c-nichols (Bitbucket: c-nichols, GitHub: c-nichols)

---

Hey guys, don't know if it's helpful but you can check my fork to see what I did to get the tests passing in python3.3. If you want me to do anything else, let me know. Sorry about the messy fork, but when it comes to hg: http://i.imgur.com/kNGKIvW.jpg :)

[redtoad]

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)

---

Got all tests to run under Python 3.4 \o/ (see #6).

[redtoad]

Original comment by peterbe (Bitbucket: peterbe, GitHub: peterbe)

---

What's next to make a PyPI release with this?

[redtoad]

Original comment by peterbe (Bitbucket: peterbe, GitHub: peterbe)

---

I get this error after installing the tip in a Python 3.5 virtualenv:

#!python

In [2]: from amazonproduct import API
   ...: api = API(locale='us')
   ...:
   ...:
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-2-5de5988f78ff> in <module>()
      1 from amazonproduct import API
----> 2 api = API(locale='us')
      3

/Users/peterbe/virtualenvs/songsearch/lib/python3.5/site-packages/python_amazon_product_api-0.3.dev0-py3.5.egg/amazonproduct/api.py in __init__(self, access_key_id, secret_access_key, locale, associate_tag, processor, cfg)
    130
    131         # instantiate processor class
--> 132         if isinstance(processor, (str, unicode)):
    133             self._processor_module = processor
    134             self.processor = load_class('%s.Processor' % processor)()

NameError: name 'unicode' is not defined

In [3]:

[redtoad]

Original comment by Jochen Lanzinger (Bitbucket: kyi87, GitHub: Unknown)

---

I get the same error, like peterbe in python 3.5

[redtoad]

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)

---

Haven't looked at this for a while. I'll see what I can do as soon as my kids allow.
In the meantime I wouldn't say no to a patch ;-)

[redtoad]

Original comment by Sebastian Rahlf (Bitbucket: basti, GitHub: basti)

---

Add support for Python 3.4 and 3.5 (see #6). This means having to resort to six outside the tests as well!

[redtoad]

Original comment by Christian Clauss (Bitbucket: cclauss, GitHub: cclauss)

---

https://pypi.python.org/pypi/python-amazon-product-api does not contain the Programming Language :: Python :: 3 trove classifier which means that scripts can not automatically determine the Python 3 compatibility of python-amazon-product-api.

[redtoad]

Original comment by ThomasProctor (Bitbucket: ThomasProctor, GitHub: ThomasProctor)

---

It looks like the pypi version hasn't been updated since commit 3a79a1c, way back in 2014. There have been lots of changes since, including support for the python that everybody is using.

Any idea on when updates will get pushed to pypi?