Remove deprecated exclude\include parameters #92
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated exclude and include parameters from the ReductStore C++ client library API as part of a breaking change cleanup. The parameters were previously deprecated in favor of the when parameter for query filtering.
- Removes deprecated
includeandexcludefields fromQueryOptionsandReplicationSettingsstructs - Eliminates associated serialization/deserialization logic for these parameters
- Updates test data to reflect license changes and removes usage of deprecated parameters
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/reduct/client.h | Removes deprecated include/exclude fields from ReplicationSettings struct |
| src/reduct/bucket.h | Removes deprecated include/exclude fields from QueryOptions struct and fixes comment formatting |
| src/reduct/internal/serialisation.cc | Removes serialization logic for include/exclude parameters |
| tests/reduct/replication_api_test.cc | Removes usage of deprecated parameters from test settings |
| tests/reduct/server_api_test.cc | Updates copyright year and license test data |
| CHANGELOG.md | Documents the removal of deprecated parameters |
| .github/workflows/ci.yml | Updates Windows build environment from 2019 to 2022 |
Comments suppressed due to low confidence (1)
tests/reduct/server_api_test.cc:44
- The hardcoded timestamp value appears to be a past date (around 2026 based on the epoch value). Consider using a future date or making this test more robust by checking if the expiry date is reasonable rather than an exact match.
REQUIRE(info.license->expiry_date.time_since_epoch().count() == 1778852143696974000);
Comment on lines
+30
to
+34
| os: [ubuntu-22.04, windows-2022] | ||
| include: | ||
| - os: ubuntu-22.04 | ||
| install: "true" | ||
| - os: windows-2019 | ||
| - os: windows-2022 |
There was a problem hiding this comment.
[nitpick] The CI environment update from windows-2019 to windows-2022 seems unrelated to the main purpose of removing deprecated parameters. Consider separating infrastructure changes into a separate PR for better change tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Removal
What was changed?
All usage of the deprecated exclude and include parameters has been removed from the codebase. These parameters are no longer supported and their presence has been fully eliminated from public APIs and internal logic.
Any references, documentation comments, or code paths that mentioned or handled exclude/include have been updated or deleted to reflect their removal.
Related issues
reductstore/reductstore#873, #91
Does this PR introduce a breaking change?
Yes
Other information: