Implement IBucket.CreateQueryLink method #93
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the IBucket.CreateQueryLink method, which enables creating query links for sharing data without requiring permissions. The implementation includes comprehensive test coverage and proper integration with the existing codebase.
- Adds new
CreateQueryLinkmethod to the IBucket interface with configurable options - Implements JSON serialization for query link options
- Provides comprehensive test coverage for various query link scenarios
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/reduct/bucket.h | Defines QueryLinkOptions struct and CreateQueryLink method interface |
| src/reduct/bucket.cc | Implements CreateQueryLink method with HTTP client integration |
| src/reduct/internal/serialisation.h | Declares QueryLinkOptionsToJsonString function |
| src/reduct/internal/serialisation.cc | Implements JSON serialization for query link options |
| tests/reduct/bucket_api_test.cc | Adds comprehensive test cases for CreateQueryLink functionality |
| CHANGELOG.md | Documents the new feature addition |
| .github/workflows/ci.yml | Updates API version tag exclusion for CI |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What was changed?
The PR introduces the
IBucket.CreateQueryLinkmethod, which is used to create query links for sharing particular data without permissions.Related issues
reductstore/reductstore#938
Does this PR introduce a breaking change?
No
Other information: