Fix order in when conditions#96
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for preserving key insertion order in query option serialization and introduces a test to verify record ordering in queries.
- Switches QueryOptionsToJsonString return type from nlohmann::json to nlohmann::ordered_json.
- Adds a new test section asserting ordered query results.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/reduct/entry_api_test.cc | Adds a new SECTION validating order of returned records. |
| src/reduct/internal/serialisation.h | Changes return type of QueryOptionsToJsonString to ordered_json to preserve key order. |
| src/reduct/internal/serialisation.cc | Implements the ordered_json change and parses nested JSON with ordered_json::parse. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
This PR fixes a bug in a query logic where the
$limitclause was applied before filtering by other query parameters such as"$score". As a result, queries like{ "&score": { "$eq": 10 }, $limit: 2 }could return incorrect results, since the limit was applied to the unfiltered set. With this change, the query now applies filters before applying the limit, ensuring the correct items are returned.Related issues
None
Does this PR introduce a breaking change?
No.
Other information:
N/A