Skip to content

Enable lock button for non-Redux connections.#1658

Open
EskiMojo14 wants to merge 4 commits intomainfrom
allow-lock-non-redux
Open

Enable lock button for non-Redux connections.#1658
EskiMojo14 wants to merge 4 commits intomainfrom
allow-lock-non-redux

Conversation

@EskiMojo14
Copy link
Copy Markdown

Currently the lock button is disabled if the app doesn't think it's talking to a Redux store - which is decided here:

if (type === 'STATE') lib = 'redux';

There doesn't seem to be a reason stated for this, and stores other than Redux can certainly implement locking, so I think it would be good to enable this. It's still hidden based on the feature option, which defaults to only being true if it's a Redux store:

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: 136ce3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@redux-devtools/app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown

@faiyun123 faiyun123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants