Open
Conversation
|
dacevedo12
reviewed
Feb 11, 2026
| for await (const data of this.socket!.subscribe(channelName)) { | ||
| this.handleMessages(data as Message<S, A>); | ||
| } | ||
| for await (const data of this.socket!.subscribe('sc-' + this.socket!.id)) { |
There was a problem hiding this comment.
Will this ever run as is? I got the fix working only by allowinig both to run concurrently
void (async () => {
for await (...)
})();
void (async () => {
for await (...)
})();
dacevedo12
reviewed
Feb 11, 2026
| this.isMonitored = false; | ||
| if (!this.socket) return; | ||
| void this.socket.unsubscribe(this.channel!); | ||
| this.socket.closeChannel(this.channel!); |
There was a problem hiding this comment.
Should we close the sc channel here aswell?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1340
Added missing subscription to socket id so that it is possible when using remote devtools to use commit, reset, revert,... functionalities.