Modernize Python 2 code to get ready for Python 3#2
Closed
cclauss wants to merge 5 commits intorefack:masterfrom
cclauss:modernize-Python-2-codes
Closed
Modernize Python 2 code to get ready for Python 3#2cclauss wants to merge 5 commits intorefack:masterfrom cclauss:modernize-Python-2-codes
cclauss wants to merge 5 commits intorefack:masterfrom
cclauss:modernize-Python-2-codes
Conversation
Contributor
cclauss
commented
Dec 1, 2018
cclauss
commented
- Use print() function in both Python 2 and Python 3
- print() is a function in Python 3.
- Old style exceptions --> new style for Python 3
- Python 3 treats old style exceptions as syntax errors but new style exceptions work as expected in both Python 2 and Python 3.
Changes the output from '0100' to '1000' and fixes the parsing of `CLTVersion()` output too in case `xcodebuild -version` prints an unexpected output.
* Use __print()__ function in both Python 2 and Python 3
* __print()__ is a function in Python 3.
* Old style exceptions --> new style for Python 3
* Python 3 treats old style exceptions as syntax errors but new style exceptions work as expected in both Python 2 and Python 3.
Owner
|
Superseded by 82c2f6e |
Owner
|
I backported nodejs/node-gyp#1335, so eh got all those fixes "for free". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.