Addressing HAL audit#11
Open
mfornet wants to merge 7 commits into
Open
Conversation
Staking and unstaking is paused when `paused` flag is true.
Validate Burn Fee Fraction. Make sure Staking Contract is always initialized with a proper burn_fee_fraction.
Make sure we only multiply with a valid ratio. Overflow is not possible this way.
Remove redundant state check on init
Use near-sdk #[private] macro instead
Use PanicOnDefault from near-sdk
Add a Pauser Role different from Owner Role
Contributor
|
This needs migrate implementation for paused_users |
Author
Do you mean this because this contract is already live? |
| } | ||
|
|
||
| pub(crate) fn inner_unstake(&mut self, account_id: &AccountId, amount: u128) { | ||
| if self.paused { |
Owner
There was a problem hiding this comment.
this dangerous - because it effectively means that owner can block people from unstaking from their pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.