Skip to content

Include Repo Search pages in isRepo; add hasRepoHeader #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 3 commits into from
Jul 28, 2022
Merged

Include Repo Search pages in isRepo; add hasRepoHeader #131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddaaba1
Include Repo Search pages in `isRepo`; add `hasRepoHeader`
fregante Jul 23, 2022
b47cf04
Finally drop awkward code path in isRepoSearch itself
fregante Jul 24, 2022
28c6d6c
Unrelated: move some comments to JSDoct
fregante Jul 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ export const isRepo = (url: URL | HTMLAnchorElement | Location = location): bool
&& !reservedNames.includes(url.pathname.split('/', 2)[1]!)
&& !isDashboard(url)
&& !isGist(url)
&& !isRepoSearch(url)
&& !isNewRepoTemplate(url);
addTests('isRepo', [
// Some of these are here simply as "gotchas" to other detections
Expand All @@ -345,6 +344,9 @@ addTests('isRepo', [
'https://github.com/sindresorhus/refined-github/issues/templates/edit', // Gotcha for isRepoIssueList
]);

export const hasRepoHeader = (url: URL | HTMLAnchorElement | Location = location): boolean => isRepo(url) && !isRepoSearch(url);
addTests('hasRepoHeader', combinedTestOnly);

// On empty repos, there's only isRepoHome; this element is found in `<head>`
export const isEmptyRepoRoot = (): boolean => isRepoHome() && !exists('link[rel="canonical"]');

Expand Down Expand Up @@ -435,9 +437,7 @@ addTests('isRepoRoot', [
'https://github.com/sindresorhus/refined-github/tree/master?files=1',
]);

// This can't use `getRepositoryInfo().path` to avoid infinite recursion:
// `getRepositoryInfo` depends on `isRepo` and `isRepo` depends on `isRepoSearch`
export const isRepoSearch = (url: URL | HTMLAnchorElement | Location = location): boolean => url.pathname.split('/')[3] === 'search';
export const isRepoSearch = (url: URL | HTMLAnchorElement | Location = location): boolean => getRepo(url)?.path === 'search';;
addTests('isRepoSearch', [
'https://github.com/sindresorhus/refined-github/search?q=diff',
'https://github.com/sindresorhus/refined-github/search?q=diff&unscoped_q=diff&type=Issues',
Expand Down Expand Up @@ -616,7 +616,8 @@ export const hasRichTextEditor = (url: URL | HTMLAnchorElement | Location = loca
|| isDiscussion(url);

addTests('hasCode', combinedTestOnly);
export const hasCode = (url: URL | HTMLAnchorElement | Location = location): boolean => // Static code, not the editor
/** Static code, not the code editor */
export const hasCode = (url: URL | HTMLAnchorElement | Location = location): boolean =>
hasComments(url)
|| isRepoTree(url) // Readme files
|| isRepoSearch(url)
Expand All @@ -628,7 +629,8 @@ export const hasCode = (url: URL | HTMLAnchorElement | Location = location): boo
|| isBlame(url);

addTests('hasFiles', combinedTestOnly);
export const hasFiles = (url: URL | HTMLAnchorElement | Location = location): boolean => // Has a list of files
/** Has a list of files */
export const hasFiles = (url: URL | HTMLAnchorElement | Location = location): boolean =>
isCommit(url)
|| isCompare(url)
|| isPRFiles(url);
Expand Down