Skip to content

Allow elements to define attribute lists of refracted elements#86

Merged
smizell merged 2 commits intorefractproject:masterfrom
danielgtaylor:daniel/attribute-elements-array
Nov 24, 2015
Merged

Allow elements to define attribute lists of refracted elements#86
smizell merged 2 commits intorefractproject:masterfrom
danielgtaylor:daniel/attribute-elements-array

Conversation

@danielgtaylor
Copy link
Contributor

This creates a new variable that can be used to define the attribute key names which are made up of non-refracted lists of refracted elements, such as source maps. It adds a test to the subclassing example to maintain code coverage. Since the sourceMap element isn't defined I have created the test with an array of string elements instead. Serialization and deserialization work for both full and compact refract.

This change will allow me to update the parse result namespace and unblock some development of source maps. The other potential blocker is how to treat e.g. element.meta.title as an element with a source map rather than a string, but let's leave that for another PR.

cc @smizell

@danielgtaylor danielgtaylor force-pushed the daniel/attribute-elements-array branch from 5f00c1a to 2fb5bee Compare November 23, 2015 22:07
@smizell
Copy link
Contributor

smizell commented Nov 23, 2015

@danielgtaylor LGTM

I think we should say this feature may not be supported in the future, so tread lightly :)

It almost feels like we could provide some pre-conversion hook for user to use when they have these kinds of scenarios, because there will be more cases that we can't automate like this. Thoughts?

@danielgtaylor danielgtaylor force-pushed the daniel/attribute-elements-array branch from 245cc95 to dc449bd Compare November 23, 2015 22:24
@smizell
Copy link
Contributor

smizell commented Nov 23, 2015

👍

smizell added a commit that referenced this pull request Nov 24, 2015
…rray

Allow elements to define attribute lists of refracted elements
@smizell smizell merged commit 831ba85 into refractproject:master Nov 24, 2015
@danielgtaylor danielgtaylor deleted the daniel/attribute-elements-array branch November 24, 2015 17:52
@pksunkara
Copy link
Contributor

Let's take the example of source maps. Why do we have to say it is a non-refracted array of refract elements? Why can't we simply say that it is a refract array element but serialising it should print plain array.

Basically, we really need to define the serialization formats rather than doing something like this.

@danielgtaylor
Copy link
Contributor Author

@pksunkara this should help: refractproject/rfcs#29

kylef added a commit that referenced this pull request Jan 9, 2018
Restore running all tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants