Allow elements to define attribute lists of refracted elements#86
Merged
smizell merged 2 commits intorefractproject:masterfrom Nov 24, 2015
Merged
Conversation
5f00c1a to
2fb5bee
Compare
Contributor
|
@danielgtaylor LGTM I think we should say this feature may not be supported in the future, so tread lightly :) It almost feels like we could provide some pre-conversion hook for user to use when they have these kinds of scenarios, because there will be more cases that we can't automate like this. Thoughts? |
245cc95 to
dc449bd
Compare
Contributor
|
👍 |
smizell
added a commit
that referenced
this pull request
Nov 24, 2015
…rray Allow elements to define attribute lists of refracted elements
Contributor
|
Let's take the example of source maps. Why do we have to say it is a non-refracted array of refract elements? Why can't we simply say that it is a refract array element but serialising it should print plain array. Basically, we really need to define the serialization formats rather than doing something like this. |
Contributor
Author
|
@pksunkara this should help: refractproject/rfcs#29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a new variable that can be used to define the attribute key names which are made up of non-refracted lists of refracted elements, such as source maps. It adds a test to the subclassing example to maintain code coverage. Since the
sourceMapelement isn't defined I have created the test with an array of string elements instead. Serialization and deserialization work for both full and compact refract.This change will allow me to update the parse result namespace and unblock some development of source maps. The other potential blocker is how to treat e.g.
element.meta.titleas an element with a source map rather than a string, but let's leave that for another PR.cc @smizell