Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reframe/core/meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ class was created or even at the instance level (e.g. doing

blacklist = [
'parameter', 'variable', 'bind', 'run_before', 'run_after',
'require_deps'
'require_deps', 'required'
]
for b in blacklist:
namespace.pop(b, None)
Expand Down
5 changes: 5 additions & 0 deletions reframe/core/variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,11 @@ def extend(self, cls):
if key in self.vars:
self.vars[key].define(value)
_assigned_vars.add(key)
elif value is Undefined:
# Cannot be set as Undefined if not a variable
raise ValueError(
f'{key!r} has not been declared as a variable'
)

# Delete the vars from the class __dict__.
for key in _assigned_vars:
Expand Down
2 changes: 2 additions & 0 deletions unittests/test_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class MyTest(rfm.RegressionTest):
run_before('run')(ext)
run_after('run')(ext)
require_deps(ext)
v = required

def __init__(self):
assert not hasattr(self, 'parameter')
Expand All @@ -28,6 +29,7 @@ def __init__(self):
assert not hasattr(self, 'run_before')
assert not hasattr(self, 'run_after')
assert not hasattr(self, 'require_deps')
assert not hasattr(self, 'required')

MyTest()

Expand Down
7 changes: 7 additions & 0 deletions unittests/test_variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,13 @@ def __init__(self):
MyTest()


def test_required_non_var():
msg = "'not_a_var' has not been declared as a variable"
with pytest.raises(ValueError, match=msg):
class Foo(rfm.RegressionTest):
not_a_var = required


def test_invalid_field():
class Foo:
'''An invalid descriptor'''
Expand Down