Skip to content

Conversation

@beckermr
Copy link
Contributor

@beckermr beckermr commented Sep 26, 2025

Description:

This PR cleans up some cruft in source version fetching, adds a few type hints, and accounts for excludes when fetching versions.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

@beckermr beckermr marked this pull request as ready for review September 26, 2025 21:55
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 70.29703% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.64%. Comparing base (84c74ba) to head (732cd02).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/update_sources.py 68.08% 30 Missing ⚠️

❌ Your patch status has failed because the patch coverage (70.29%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4829      +/-   ##
==========================================
- Coverage   80.70%   80.64%   -0.07%     
==========================================
  Files         143      143              
  Lines       16459    16485      +26     
==========================================
+ Hits        13284    13295      +11     
- Misses       3175     3190      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beckermr beckermr merged commit e7eb87f into main Sep 27, 2025
9 of 12 checks passed
@beckermr beckermr deleted the ver-source-fixes branch September 27, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants