Bump vibe-d to 0.8.3-alpha.1#44
Conversation
|
Rebased to rekick Travis as there was were weird issues with fetching the log. |
|
Ping @s-ludwig - there just seems to be a Python issue with Travis. As this is the last bit that's missing for dlang/phobos#5921 it would be really cool to have it in ;-) |
examples/htmlserver/source/app.d
Outdated
| void render(scope HTTPServerRequest req, scope HTTPServerResponse res) | ||
| { | ||
| auto dst = StreamOutputRange(res.bodyWriter); | ||
| auto dst = StreamOutputRange(res.bodyWriter.asInterface!OutputStream); |
There was a problem hiding this comment.
This is to avoid this error:
source/app.d(8,30): Error: template vibe.stream.wrapper.StreamOutputRange cannot deduce function from argument types !()(InterfaceProxy!(OutputStream)), candidates are:
/home/seb/.dub/packages/vibe-d-0.8.3-alpha.2/vibe-d/stream/vibe/stream/wrapper.d(290,32): vibe.stream.wrapper.StreamOutputRange()(OutputStream stream)
/home/seb/.dub/packages/vibe-d-0.8.3-alpha.2/vibe-d/stream/vibe/stream/wrapper.d(292,1): vibe.stream.wrapper.StreamOutputRange(OutputStream, ulong buffer_size = 256) if (isOutputStream!OutputStream)
Is the InterfaceProxy really necessary? Looks like it creates a lot of problems with the upcoming 0.8.3
There was a problem hiding this comment.
I think streamOutputRange(res.bodyWriter) should work here (without the additional overhead of asInterface). Unfortunately InterfaceProxy is still necessary when using vibe-core, but eventually all uses of it will be replaced by static types using templates.
There was a problem hiding this comment.
I thought so too, but DMD tells me otherwise: https://travis-ci.org/rejectedsoftware/diet-ng/jobs/332745186
There was a problem hiding this comment.
Ah, note the small s. It's just a constructor wrapper to enabled IFTI.
There was a problem hiding this comment.
Ah, note the small s
Note sure what you mean by this?
There was a problem hiding this comment.
It's streamOutputRange vs. StreamOutputRange. The former is the correct one and the latter is what appears to be called for the failing build output.
There was a problem hiding this comment.
Ah got it. Thanks!
|
@ximion meson is failing here too with DMD 2.078.0, e.g. https://travis-ci.org/rejectedsoftware/diet-ng/jobs/332860354 |
|
Thanks, finally passing! |
|
@wilzbach Makes sense - I will fix up everything when Meson releases some release that works again :P |
3 participants
Vibe.d 0.8.3 won't include
std.experimental.allocatoranymore.See also: vibe-d/vibe.d#1983
Needed for dlang/phobos#5921