Skip to content

Conversation

@yuki-mt
Copy link
Member

@yuki-mt yuki-mt commented Feb 7, 2019

What is this PR for?

update grpc submodule to pass E2E test in rekcurd/dashboard#72

This PR includes

What type of PR is it?

Feature

What is the issue?

N/A

How should this be tested?

@codecov-io
Copy link

codecov-io commented Feb 8, 2019

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files           8        8           
  Lines         293      293           
=======================================
  Hits          256      256           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f33ce...27d9bc3. Read the comment docs.

Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keigohtr keigohtr merged commit e95888f into master Feb 8, 2019
@keigohtr keigohtr deleted the feature/add_label_to_metrics branch February 8, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants