Skip to content

Conversation

@keigohtr
Copy link
Member

What is this PR for?

To improve test coverage.

This PR includes

  • Add test

What type of PR is it?

Feature

What is the issue?

#16

How should this be tested?

$ python -m unittest

@codecov-io
Copy link

Codecov Report

Merging #20 into master will increase coverage by 7.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #20      +/-   ##
=========================================
+ Coverage   87.37%   94.8%   +7.43%     
=========================================
  Files           8       6       -2     
  Lines         293     289       -4     
=========================================
+ Hits          256     274      +18     
+ Misses         37      15      -22
Impacted Files Coverage Δ
rekcurd_client/logger/logger_fluent.py 100% <100%> (+53.84%) ⬆️
rekcurd_client/logger/logger_jsonlogger.py 100% <100%> (+25%) ⬆️
rekcurd_client/core/__init__.py 100% <100%> (ø)
rekcurd_client/core/rekcurd_worker_client.py 95.16% <100%> (ø)
rekcurd_client/_project.py
rekcurd_client/_version.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95888f...15e522b. Read the comment docs.

@keigohtr keigohtr merged commit 480af39 into master Feb 13, 2019
@keigohtr keigohtr deleted the feature/add-test branch February 13, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants