Skip to content

Conversation

@keigohtr
Copy link
Member

What is this PR for?

Update to the latest rekcurd spec.

This PR includes

  • Renew rekcurd-client initializer
  • Update to the latest rekcurd spec
  • Update test

What type of PR is it?

Feature

What is the issue?

N/A

How should this be tested?

$ python -m unittest

@keigohtr keigohtr self-assigned this Feb 18, 2019
@codecov-io
Copy link

codecov-io commented Feb 21, 2019

Codecov Report

Merging #21 into master will decrease coverage by 1.01%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage    94.8%   93.79%   -1.02%     
==========================================
  Files           6        6              
  Lines         289      290       +1     
==========================================
- Hits          274      272       -2     
- Misses         15       18       +3
Impacted Files Coverage Δ
rekcurd_client/logger/__init__.py 100% <ø> (ø) ⬆️
rekcurd_client/core/rekcurd_worker_client.py 93.77% <76.19%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480af39...e5373b4. Read the comment docs.

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to change How to Use section in README and sample.py as well.
(and I don't think sample.py is necessary because How to Use section in README has the same code and the section describe the sample better)

@keigohtr
Copy link
Member Author

@yuki-mt Thank you for your review.
I have added a new repository here for an example, and have deleted sample.py, and have updated README.md.
Could you review this again please?

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keigohtr keigohtr merged commit e214b8d into master Feb 28, 2019
@keigohtr keigohtr deleted the feature/apply-latest-rekcurd branch February 28, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants