Add support for passing per-message metadata.MD #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for per-message (client-side) metadata md.MD to be passed in Gorums' Metadata object. This allows a client (or interceptor) to pass custom data to the server replicas. For example, a client can pass its client-id or request-id to the server, independent of the application-level message used.
This just adds a comment to the doc for a few methods that should only be called from generated code.
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for per-message (client-side) metadata.MD to be passed in Gorums' Metadata object. This allows a client (or interceptor) to pass custom data to the server replicas. For example, a client can pass its client-id or request-id to the server, independent of the application-level message.
Note that this does not support canceling unary quorum calls etc. I've decided to defer adding support for cancellation until I understand it better.
Fixes #219
Fixes #172