Cue/cli compatibility fixes #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meling
reviewed
Jan 22, 2025
| return nil, err | ||
| } | ||
| opt.SetTreeOptions(e.hostCfg.BranchFactor, e.hostCfg.TreePositions, e.hostCfg.TreeDelta) | ||
| // opt.SetTreeOptions(e.hostCfg.BranchFactor, e.hostCfg.TreePositions, e.hostCfg.TreeDelta) |
Member
| numReplicas := viper.GetInt("replicas") | ||
| numClients := viper.GetInt("clients") | ||
|
|
||
| // Kauri values |
|
|
||
| cfgPath := viper.GetString("cue") | ||
|
|
||
| treeDelta := viper.GetDuration("tree-delta") |
Member
There was a problem hiding this comment.
These belong together with tree values above (bf)
|
|
||
| var cfg *config.HostConfig | ||
| if cfgPath != "" { | ||
| cfg, err = config.Load(cfgPath) |
Member
There was a problem hiding this comment.
I believe Load was renamed in the other PR.
| replicaHosts := viper.GetStringSlice("replica-hosts") | ||
| clientHosts := viper.GetStringSlice("client-hosts") | ||
|
|
||
| var cfg *config.HostConfig |
| } | ||
| if viper.GetBool("random-tree") { | ||
| rnd := rand.New(rand.NewSource(rand.Uint64())) | ||
| rnd.Shuffle(len(treePos), reflect.Swapper(treePos)) |
Member
There was a problem hiding this comment.
We now have tree.Shuffle() for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
--hostscli flag was omitted when integrating Cue. Now I have introduced--client-hostsand--replica-hoststo the cli so that things can work like before and be compatible with Cue if the user chooses to.Upon implementing this fix, I see that the choice between Cue and Viper cli configuration can be improved so I opened issue #168