Refactor module system #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 57.81% 62.70% +4.88%
==========================================
Files 70 73 +3
Lines 6427 7197 +770
==========================================
+ Hits 3716 4513 +797
+ Misses 2424 2384 -40
- Partials 287 300 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
johningve
force-pushed
the
module-refactor
branch
from
eb45738 to
042e6b4
Compare
Member
Author
|
@meling I decided to drop the explicit |
johningve
force-pushed
the
module-refactor
branch
2 times, most recently
from
33da9e6 to
65ace61
Compare
Member
Author
|
@meling I have myself reviewed all the changes and am happy with what is here. If you think that the changes to the module system look okay, then I think that we can merge it |
johningve
force-pushed
the
module-refactor
branch
from
65ace61 to
4dc32c9
Compare
This removes the need to declare what "interface" or type a module provides to the module system, thus being more in line with the "Go way" of implicit interfaces. The module system looks for a module with a compatible type. If multiple modules implement the same type, the module system chooses the one that was added to the builder last.
meling
reviewed
Aug 22, 2022
meling
reviewed
Aug 22, 2022
meling
reviewed
Aug 22, 2022
meling
reviewed
Aug 22, 2022
meling
reviewed
Aug 22, 2022
johningve
force-pushed
the
module-refactor
branch
2 times, most recently
from
e622d02 to
040b049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the module system works. Modules can no longer directly access a module through the "Core" object in this manner:
mods.Eventloop(). Instead, modules are expected to declare a local variable that should hold the module, and then call one of the newGetmethods to retrieve the module. For example:Additionally, this PR adds a document that describes the ideas behind the module system and why it is necessary, and fixes a couple of mistakes.