Removed leafBlock from synchronizer #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandernikolaus
commented
Sep 23, 2022
| } | ||
|
|
||
| if newBlock.View() > oldBlock.View() { | ||
| if newBlock.View() > s.highQC.View() { |
Contributor
Author
There was a problem hiding this comment.
I believe this change should be done, even when not removing leafBlock.
Member
|
I've looked at the code, and it looks fine to me. But could edit the PR description to provide some more context for this. Do you think we won't need the |
meling
changed the title
Member
|
I don't see any issues with this PR. @hanish520 Would this conflict with any of your other changes? @johningve If you have a cycle to spare, please let us know your take. I want to merge this if there are no concerns with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to study the semantics of the synchronizer, and I found that the
leafBlockis always the block from thehighQC.Therefore, in the current implementation, we could omit the
leafBlock.