Skip to content

fix: use domhandler exports field#286

Closed
vattenapa wants to merge 1 commit intoremarkablemark:masterfrom
vattenapa:domhandler-import
Closed

fix: use domhandler exports field#286
vattenapa wants to merge 1 commit intoremarkablemark:masterfrom
vattenapa:domhandler-import

Conversation

@vattenapa
Copy link
Copy Markdown

Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @vattenapa!

Do you mind updating the karma.conf.js:

npm run test:client

And updating .size-limit.json since this change increases the bundle size?

npm run size-limit

@vattenapa
Copy link
Copy Markdown
Author

Wait a sec, I was using resolutions in package.json to fix domhandler to ^5. The exports for domhandler:4.3.1 don't have this issue.

I'll close this PR since this package isn't compatible with domhandler 5, sorry about that.

@vattenapa vattenapa closed this May 31, 2022
@remarkablemark
Copy link
Copy Markdown
Owner

No worries! @vattenapa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants