fix: use domhandler exports field#286
Closed
vattenapa wants to merge 1 commit intoremarkablemark:masterfrom
vattenapa:domhandler-import
Closed
fix: use domhandler exports field#286vattenapa wants to merge 1 commit intoremarkablemark:masterfrom vattenapa:domhandler-import
vattenapa wants to merge 1 commit intoremarkablemark:masterfrom
vattenapa:domhandler-import
Conversation
remarkablemark
requested changes
May 31, 2022
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
Thanks for opening this PR @vattenapa!
Do you mind updating the karma.conf.js:
- https://github.com/remarkablemark/html-dom-parser/blob/0cf76d3/karma.conf.js#L18
- https://github.com/remarkablemark/html-dom-parser/blob/0cf76d3/karma.conf.js#L37
npm run test:clientAnd updating .size-limit.json since this change increases the bundle size?
npm run size-limit
Author
|
Wait a sec, I was using I'll close this PR since this package isn't compatible with domhandler 5, sorry about that. |
Owner
|
No worries! @vattenapa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as remarkablemark/html-react-parser#565