Skip to content

Conversation

@remarkablemark
Copy link
Owner

What is the motivation for this pull request?

fix: move @types/react to dependencies and fix esm types

Fixes #1313

What is the current behavior?

Default import has return type of any

What is the new behavior?

Default import has valid return type

Checklist:

@remarkablemark remarkablemark added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 14, 2024
@remarkablemark remarkablemark self-assigned this Feb 14, 2024
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.17 KB (0%) 184 ms (0%) 41 ms (+9.85% 🔺) 225 ms

@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16b5ccf) 100.00% compared to head (e3c7931) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1314   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        49        49           
=========================================
  Hits           151       151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remarkablemark remarkablemark merged commit 0e6d27f into master Feb 14, 2024
@remarkablemark remarkablemark deleted the fix/types branch February 14, 2024 00:20
@remarkablemark
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type of parse is any

2 participants