Added default value to link's "rel" when link's "target" is "_blank"

[galabra]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

When a link's target is set to _blank, the consensus is adding rel="noopener noreferrer".
I added this as the default behavior and also allowed overriding this value.

This was discussed in the past: #413 and in the prehistoric #12

[wooorm]

Did you see the related issues when searching for rel?
#350 or more recently for example #65 (comment).

What is your aversion to using a plugin instead of passing options?

[galabra]

@wooorm Woah, I wasn't looking thoroughly enough and didn't see #350.
For simplicity sake, I honestly assumed the consensus and should be the default option here.

[wooorm]

It’s an old issue from before plugins worked. They are closed because there is a better alternative.
The defaults are safe: don‘t use _target.
If anything, I’d remove linkTarget. It’s a bad idea anyway; I think it’s better to let users choose where they open things. E.g., https://css-tricks.com/use-target_blank/.

[galabra]

I beg to differ 🙂
Installing additional dependencies is never a good thing, but a tradeoff.
What good reason is there to not extend this functionality?

[wooorm]

Everything is a trade off. The trade off here is between a small project that everyone uses or a big project with features many people do not use.
Another good reason is that people can already do this: pass an a component.
Another reason is that users will want to do different things, plugins allow that

[galabra]

IMO this should be a part of this library, however I understand where you're coming from.
Thank you for the suggestion to create a custom component, I didn't know it existed!

For future generations, this is what I ended up with:

<ReactMarkdown
    components={{
        a: ({
            node, href, children, ...props
        }) => <a href={href} target="_blank" rel="noopener noreferrer" {...props}>{children}</a>,
    }}
>
    {markdownText}
</ReactMarkdown>

[wooorm]

Glad you found something that works, and thanks for the PR!