Fix identity encryption always using piv-p256 instead of p256tag/mlkem768p256tag#17
Open
GaMoCh wants to merge 1 commit into
Open
Fix identity encryption always using piv-p256 instead of p256tag/mlkem768p256tag#17GaMoCh wants to merge 1 commit into
GaMoCh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-i), the plugin always usedpiv-p256stanza type, ignoring post-quantum keysmlkem768p256tagwhen the identity has ML-KEM keys, andp256tagotherwiseage-plugin-yubikeybehavior of always using modern stanza types for encryptionBefore / After
Before
After
Details
The
runRecipientV1function hardcoded.pivp256for all identities passed viaadd-identity, even when the identity contained ML-KEM-768 keys generated with--pq.This meant
age -e -i key.txtnever used post-quantum encryption.Recipients passed via
add-recipient(-r) already correctly detected the stanza typefrom the recipient string prefix. This fix applies equivalent logic for identities,
using the available key material to determine the appropriate stanza type.