Adding lifetime options #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding lifetime options for registering Maps with the DI container. No breaking changes in this PR, only the addition to configure how your Maps are registered (Singleton, or Transient). Registering Maps as Singleton drastically reduces the amount of memory allocations in the process of running a map through the mapper.
Registered as Transient and calling mapper over many iterations causes a lot of GC time and allocation
Adding the
[Map(Lifetime = MapLifetime.Singleton)]to the map now completely removes that allocationThe default behaviour of the registration is still to register maps as
Transient, but I would highly recommend keeping maps as pure and register them asSingleton.