(feat): Adding mixed policy instance overrides#189
Merged
skipi merged 9 commits intorenderedtext:masterfrom Jan 7, 2026
Merged
(feat): Adding mixed policy instance overrides#189skipi merged 9 commits intorenderedtext:masterfrom
skipi merged 9 commits intorenderedtext:masterfrom
Conversation
Contributor
|
/sem-approve |
1 similar comment
Contributor
Author
|
/sem-approve |
975d9c4 to
9d2a92a
Compare
Add support for specifying instance requirements in Auto Scaling Group mixed instances policy LaunchTemplateOverrides. Configuration is provided via SEMAPHORE_AGENT_MIXED_POLICY_INSTANCE_REQUIREMENTS_JSON parameter as JSON, allowing full control over instance selection attributes.
9d2a92a to
66d57bb
Compare
Contributor
Author
|
/sem-approve |
Contributor
Author
|
@dexyk, could you please facilitate the merging of this pull request? This enhancement provides greater flexibility in applying overrides. For instance, in our forked version, we are currently utilizing it as follows: This approach allows us to define specific instance configuration requirements rather than hardcoding instance types, which mitigates issues related to the availability of a particular instance type. |
Add SEMAPHORE_AGENT_ASG_NEW_INSTANCES_PROTECTED_FROM_SCALE_IN parameter to control whether new instances in the Auto Scaling Group are protected from scale-in operations. Defaults to false.
skipi
approved these changes
Jan 7, 2026
Member
|
/sem-approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.