SAM_SPI: Fix IndexOutOfRangeException in SetDmaAccessWidth#199
Open
msarehn wants to merge 1 commit intorenode:masterfrom
Open
SAM_SPI: Fix IndexOutOfRangeException in SetDmaAccessWidth#199msarehn wants to merge 1 commit intorenode:masterfrom
msarehn wants to merge 1 commit intorenode:masterfrom
Conversation
When the SPI Mode Register PCS field is set to 0xF (no chip select active), ChipSelect() computes selectedSlaveAddr=4 via GetLeastSignificantZero/Logarithm2. SetDmaAccessWidth() then accesses txLengths[4] which is out of bounds for the 4-element array (indices 0-3), causing an unhandled IndexOutOfRangeException that crashes the emulation. Guard the array access in SetDmaAccessWidth() and fall back to byte-width DMA when the computed slave register number exceeds the array bounds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SPI Mode Register PCS field is set to 0xF (no chip select active), ChipSelect() computes selectedSlaveAddr=4 via GetLeastSignificantZero/Logarithm2. SetDmaAccessWidth() then accesses txLengths[4] which is out of bounds for the 4-element array (indices 0-3), causing an unhandled IndexOutOfRangeException that crashes the emulation.
Guard the array access in SetDmaAccessWidth() and fall back to byte-width DMA when the computed slave register number exceeds the array bounds.
This is part of a larger effort to properly emulate SAM4E-based devices.