Conversation
Contributor
Author
|
Holding in draft until we have test coverage. |
mattt
force-pushed
the
mattt/retry-policy
branch
from
78f6280 to
dc1fbd2
Compare
mattt
force-pushed
the
mattt/retry-policy
branch
from
dc1fbd2 to
0975aa2
Compare
mattt
commented
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #114
This PR introduces a new
withAutomaticRetryfunction that wraps requests made withfetchto automatically retry them as appropriate (429 status code, as well as 5xx errors forGETrequests). If the server sends aRetry-Afterheader, that value is used. Otherwise, the function delays for a configured interval with exponential backoff and jitter.This should all be in line with the retry logic in the Python client.