Remove the node protocol from the require statement#250
Merged
Conversation
Contributor
Author
|
Urgh, this is probably a no-go too, if we remove the |
ab30893 to
2e68c8d
Compare
mattt
reviewed
May 2, 2024
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "name": "replicate-next", | |||
Contributor
There was a problem hiding this comment.
@aron Thanks for taking the time to add an integration test for Next.js!
mattt
approved these changes
May 2, 2024
Contributor
mattt
left a comment
There was a problem hiding this comment.
I love this. Thanks so much for your work on this. Here's hoping that this will resolve the issues folks were having with standard library imports.
This should improve the situation for certain JavaScript bundlers in the ecosystem which do not like the `node:crypto` require statement.
2e68c8d to
6ae67a2
Compare
This was referenced May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve the situation for certain JavaScript bundlers in the ecosystem which do not like the
node:cryptorequire statement, see #225 and #243.