Conversation
aron
approved these changes
May 13, 2024
Contributor
aron
left a comment
aron
left a comment
There was a problem hiding this comment.
Looks great, one minor comment to also document the fallback arguments for when the environment doesn't support the Request API.
|
|
||
| return NextResponse.json({ detail: "Webhook is valid" }, { status: 200 }); | ||
| } | ||
| ``` |
Contributor
There was a problem hiding this comment.
We should cover what to do if your environment doesn't support Request, in which case you pass through the parts manually:
const requestData = {
id: "123", // the `Webhook-Id` header
timestamp: 0123456, // the `Webhook-Timestamp` header
signature: "xyz", // the `Webhook-Signature` header
body: "", // the request body as a string, ArrayBuffer or ReadableStream
};
const webhookIsValid = await validateWebhook(requestData, secret);
Member
Author
There was a problem hiding this comment.
Yeah good point. I opened an issue to follow up on that: #261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #195