Allow configuring axios, this enables eg passing an axios adapter which runs outside of node#29
Allow configuring axios, this enables eg passing an axios adapter which runs outside of node#29nfcampos wants to merge 1 commit intoreplicate:mainfrom
Conversation
…ch runs outside of node
|
Hey @nfcampos 👋🏼 Thanks for the PR. I heard about you from @hwchase17, whom I met last night at a meetup. I'm guessing you're proposing this change in relation to @cbh123's PR to add Replicate support to langchainjs? langchain-ai/langchainjs#510 A couple thoughts:
|
The decision to use axios was entirely pragmatic — it was the first thing I got working, so I went with that. I'd be very open to dropping it entirely for Speaking more directly to this PR: How we make HTTP requests is an implementation detail that we shouldn't expose to the public API. If we want users to configure how this is done, we should advise them to replace |
|
The only purpose this would serve for me (LangChain) is precisely to replace the implementation with a fetch-based adapter, so that this can be used outside Node. We already do this with the openai sdk which also (unfortunately) uses axios. I agree with your comments re: not wanting to be tied to axios, this was just a lot less work for me than rewriting your whole library to use fetch |
No description provided.