Skip to content

Throw an error if webhook URL is invalid#84

Merged
mattt merged 1 commit intomainfrom
mattt/validate-webhook-url
Jun 12, 2023
Merged

Throw an error if webhook URL is invalid#84
mattt merged 1 commit intomainfrom
mattt/validate-webhook-url

Conversation

@mattt
Copy link
Copy Markdown
Contributor

@mattt mattt commented Jun 12, 2023

Resolves #81

This PR updates the predictions.create and trainings.create methods to throw an error if the provided webhook parameter isn't a valid URL (as determined by the built-in URL constructor).

@mattt mattt merged commit 7ed6bb1 into main Jun 12, 2023
@mattt mattt deleted the mattt/validate-webhook-url branch June 12, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Providing an invalid webhook URL to predictions.create doesn't return any feedback

1 participant