Rename BaseModel and Collection to Resource and Namespace#188
Merged
Conversation
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Move Namespace to resource.py Signed-off-by: Mattt Zmuda <mattt@replicate.com>
…form Signed-off-by: Mattt Zmuda <mattt@replicate.com>
mattt
added a commit
that referenced
this pull request
Nov 7, 2023
Related to #188 API resources define a common `id` field, which requires additional bookkeeping in `_prepare_model`. However, these fields aren't used, and either shadow a field on the resource or can be computed. This PR removes `id` from the base model, adds properties for subclasses that don't have an `id` field (like `Hardware` and `Collection`), and marks them as deprecated, for anyone who is relying on that behavior. --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some ambiguity with
pydantic.BaseModeland Replicate models, and resolves a naming conflict with Replicate model collections.API consumers are unlikely to interact with these symbols directly, so this change should be largely backward compatible.